Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax torchdata torch conda requirement to >= 2.0 #1213

Closed
wants to merge 2 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Nov 1, 2023

This is similar to #1210, but relax the requirement for conda build instead of wheel. For example, linux-64/torchdata-0.7.0-py39.tar.bz2 conda packages on https://anaconda.org/pytorch-test/torchdata/files currently has the following deps openssl >=3.0.11,<4.0a0, python >=3.9,<3.10.0a0, pytorch 2.1.0, requests, urllib3 >=1.25, zlib >=1.2.13,<1.3.0a0 where pytorch is fixed at 2.1.0

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2023
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn merged this pull request in a5b4720.

huydhn added a commit that referenced this pull request Nov 1, 2023
Summary:
This is similar to #1210, but relax the requirement for conda build instead of wheel.  For example, `linux-64/torchdata-0.7.0-py39.tar.bz2` conda packages on https://anaconda.org/pytorch-test/torchdata/files currently has the following deps `openssl >=3.0.11,<4.0a0, python >=3.9,<3.10.0a0, pytorch 2.1.0, requests, urllib3 >=1.25, zlib >=1.2.13,<1.3.0a0` where [pytorch](https://anaconda.org/pytorch-test/pytorch) is fixed at `2.1.0`

Pull Request resolved: #1213

Reviewed By: seemethere

Differential Revision: D50897499

Pulled By: huydhn

fbshipit-source-id: cf748914962e00565e2d4f53734fceb429555769
@andrewkho andrewkho deleted the relax-pytorch-conda-requirement branch September 26, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants